fix: update deprecated imports from ovos-utils #300
Conversation
WalkthroughThe pull request modifies the import path for the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Warning Rate limit exceeded@JarbasAl has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 28 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #300 +/- ##
==========================================
- Coverage 53.41% 51.65% -1.76%
==========================================
Files 37 36 -1
Lines 4362 4191 -171
==========================================
- Hits 2330 2165 -165
+ Misses 2032 2026 -6 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
test/unittests/test_abstract_app.py (2)
Line range hint
13-14: Critical: Fix constructor method name typoThe constructor method is incorrectly named
__int__instead of__init__. This prevents proper class initialization and skips the parent class initialization.Apply this fix:
- def __int__(self, *args, **kwargs): + def __init__(self, *args, **kwargs): super().__init__(*args, **kwargs)
Line range hint
71-76: Consider implementing the TODO test methodsThe
test_get_language_dirandtest_clear_intentsmethods are currently empty with TODO comments. These tests are important for ensuring proper functionality.Would you like me to help implement these test methods or create GitHub issues to track them?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (12)
ovos_workshop/skills/ovos.py(1 hunks)test/unittests/skills/test_active.py(1 hunks)test/unittests/skills/test_base.py(1 hunks)test/unittests/skills/test_common_query_skill.py(1 hunks)test/unittests/skills/test_fallback_skill.py(1 hunks)test/unittests/skills/test_idle_display_skill.py(1 hunks)test/unittests/skills/test_ovos.py(1 hunks)test/unittests/test_abstract_app.py(1 hunks)test/unittests/test_decorators.py(1 hunks)test/unittests/test_skill.py(1 hunks)test/unittests/test_skill_launcher.py(1 hunks)test/unittests/test_skill_loader.py(1 hunks)
✅ Files skipped from review due to trivial changes (11)
- ovos_workshop/skills/ovos.py
- test/unittests/skills/test_active.py
- test/unittests/skills/test_base.py
- test/unittests/skills/test_common_query_skill.py
- test/unittests/skills/test_fallback_skill.py
- test/unittests/skills/test_idle_display_skill.py
- test/unittests/skills/test_ovos.py
- test/unittests/test_decorators.py
- test/unittests/test_skill.py
- test/unittests/test_skill_launcher.py
- test/unittests/test_skill_loader.py
🔇 Additional comments (1)
test/unittests/test_abstract_app.py (1)
6-6: LGTM! Verify consistent usage across codebase.
The import path update aligns with the PR objective of updating deprecated imports.
Let's verify that all imports of FakeBus have been updated consistently:
✅ Verification successful
All FakeBus imports are using the new path consistently
The verification shows that all instances of FakeBus imports across the codebase are using the new ovos_utils.fakebus path consistently. No deprecated imports from ovos_utils.messagebus were found.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for any remaining deprecated imports of FakeBus
# and verify the new import path is used consistently
# Check for any remaining old imports
echo "Checking for deprecated imports..."
rg "from ovos_utils.messagebus import FakeBus"
# Check usage of new import path
echo "Checking new import usage..."
rg "from ovos_utils.fakebus import FakeBus"
Length of output: 1168
Summary by CodeRabbit
Bug Fixes
Applicationclass constructor from__int__to__init__.Chores
FakeBusacross multiple files to reflect new module organization fromovos_utils.messagebustoovos_utils.fakebus.